Update serialization to use HTML instead of XML #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents CDATA sections, erroneous self-closing tags, and un-booleanized attributes from happening.
westonruter
force-pushed
the
update/html-serialization
branch
from
25b1fd9 to
a0ceeac
Compare
|
Rebased to resolve merge conflict. Former |
ThierryA
approved these changes
Jan 24, 2018
This was referenced Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMDocument::saveHTML($node)has not available since it was introduced in 5.3. UsingsaveXMLinstead causes other problems, including injection of CDATA sections, unbooleanized attributes, and self-closing tags. Instead of trying to work around all of these issues to continue supporting PHP 5.2, I think it would be more sensible to update the minimum requirement to PHP 5.3.