Issue #1157: Display schema.org image data for 'attachment' post type #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported on a support topic, on Native AMP, on 'attachment' pages, there's no schema.org data for the image. So add a conditional to check for this post type. It's possible that the attachment is a video, like a .mov file. In that case, it won't return an image. wp_get_attachment_image_src() will return false. @see https://wordpress.org/support/topic/structured-data-error-for-attachment-pages-media/
There was a failed Travis build. So align the = signs with line 387.
westonruter
requested changes
May 25, 2018
includes/amp-helper-functions.php
Outdated
| @@ -524,6 +524,8 @@ function amp_get_post_image_metadata( $post = null ) { | |||
|
|
|||
| if ( has_post_thumbnail( $post->ID ) ) { | |||
| $post_image_id = get_post_thumbnail_id( $post->ID ); | |||
| } elseif ( 'attachment' === $post->post_type ) { | |||
There was a problem hiding this comment.
What if the attachment isn't an image? I think this should also include wp_attachment_is( 'image', $post )
There was a problem hiding this comment.
Thanks, commit 15ea3d ensures the attachment is an image.
Props @westonruter for the conditional check. This ensures that the attachment isn't another type, like a video. In that case, wp_get_attachment_image_src() won't return image data.
westonruter
approved these changes
May 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 'attachment' pages in Native AMP, there's no schema.org data for the image.
This adds a conditional to check for the post type of 'attachment.'
It's possible that the attachment is a video, like a
.movfile. In that case, it won't return an image.As reported in this support topic: https://wordpress.org/support/topic/structured-data-error-for-attachment-pages-media/
Closes #1157.