[Gutenberg] Add AMP media blocks #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
changed the title
|
Conflicts need to be resolved. |
|
@westonruter Conflicts resolved. |
westonruter
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following media blocks:
Also todo:
Relevant notes
Note that the PR is not trying to embed the players inside the editor and instead is displaying the following placeholder (similar to core Facebook embed block):
Includes all the relevant fields for configuring the AMP component and also layout, width, and height attributes. For example:
There are some @todo comments in the code which could potentially be considered for the next iteration of the blocks.