Keep track of the callbacks run (and their sources) when a filter is applied #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…applied * Wrap the_content and the_excerpt in AMP stack source comments to reveal which filters are responsible for the resulting content, since not any one filter callback can be identified as the culprit for invalid content. * Remove spurious apostrophe from callback class name. * Prevent PHP notice when doing summarize_validation_errors if a source has no type or name.
|
Here's what it looks like when there is invalid content output by a shortcode: both the shortcode being applied and the filter (
|
kienstra
approved these changes
Mar 13, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
This looks good. It's nice how it has a stack trace of the filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I enter an excerpt that contains:
Now this results in the validation error containing the filter that is applied (
the_excerpt), the current post global, and the filter callbacks added and their sources:This will greatly help with debugging AMP validation errors related to filters, where previously there was only good validation debugging for actions.