You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tl;dr: We can remove this jQuery listener because (1) jQuery selector is no longer found, and (2) there is no issue with custom statuses and Quick Edit right now.
However, Quick Edit is currently a button element. Its HTML looks like this:
<buttontype="button" class="button-link editinline" aria-label="Quick edit “Add a new post – set this for future” inline" aria-expanded="false">Quick Edit</button>
Also, in the browser console, I can double check that with these functions:
jQuery('#the-list a.editinline').length returns 0
jQuery('#the-list button.editinline').length returns 20 (or the number of posts on this screen).
That said, I am not seeing any issue with Quick Edit and custom statuses here.
The text was updated successfully, but these errors were encountered:
From https://github.com/Automattic/Edit-Flow/pull/649/files#r645296481
Expected/Desired Behavior
Remove the redundancy code.
Code:
http://github.com/Automattic/Edit-Flow/blob/8a52203127b483576410558f940097e583d6ef3d/modules/custom-status/lib/custom-status.js#L84-L87
Details
tl;dr: We can remove this jQuery listener because (1) jQuery selector is no longer found, and (2) there is no issue with custom statuses and
Quick Edit
right now.As mentioned in the comment here, this
click
event is triggered ifQuick Edit
links are clicked in http://valet-vipgo-3279.test/wp-admin/edit.phpHowever,
Quick Edit
is currently a button element. Its HTML looks like this:Also, in the browser console, I can double check that with these functions:
jQuery('#the-list a.editinline').length
returns 0jQuery('#the-list button.editinline').length
returns20
(or the number of posts on this screen).That said, I am not seeing any issue with
Quick Edit
and custom statuses here.The text was updated successfully, but these errors were encountered: