Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery and WP 5.6: fix warnings #632

Closed
htdat opened this issue Apr 14, 2021 · 1 comment · Fixed by #649
Closed

jQuery and WP 5.6: fix warnings #632

htdat opened this issue Apr 14, 2021 · 1 comment · Fixed by #649

Comments

@htdat
Copy link
Member

htdat commented Apr 14, 2021

Expected/Desired Behavior

No error when using this plugin https://wordpress.org/plugins/enable-jquery-migrate-helper/

Actual Behavior

When using WordPress 5.7 and the plugin above, there are a lot of warnings in the following. I am categorizing them into two types: Libraries and Edit-Flow own code

Libraries:

/edit-flow/common/js/jquery.listfilterizer.js: jQuery.expr[':'] is deprecated; use jQuery.expr.pseudos

/edit-flow/common/js/jquery.quicksearch.js: jQuery.fn.keydown() event shorthand is deprecated
/edit-flow/common/js/jquery.quicksearch.js: jQuery.fn.submit() event shorthand is deprecated

/edit-flow//common/js/screen-options.js: jQuery.fn.change() event shorthand is deprecated

/edit-flow/common/js/jquery-ui-timepicker-addon.js: jQuery.fn.focus() event shorthand is deprecated
/edit-flow/common/js/jquery-ui-timepicker-addon.js: jQuery.fn.bind() is deprecated

Edit-flow code:

/edit-flow/modules/calendar/lib/calendar.js: jQuery.fn.click() event shorthand is deprecated
/edit-flow/modules/calendar/lib/calendar.js: jQuery.fn.keydown() event shorthand is deprecated
/edit-flow/modules/calendar/lib/calendar.js: jQuery.fn.hover() is deprecated

/edit-flow/modules/story-budget/lib/story-budget.js: jQuery.fn.click() event shorthand is deprecated

/edit-flow/modules/settings/lib/settings.js: jQuery.fn.click() event shorthand is deprecated

/edit-flow/modules/custom-status/lib/custom-status-configure.js: jQuery.fn.live() is deprecated

/edit-flow/modules/editorial-metadata/lib/editorial-metadata-configure.js: jQuery.fn.live() is deprecated

/edit-flow/modules/user-groups/lib/user-groups-configure.js: jQuery.fn.live() is deprecated

(Optional) Additional notes

Reported here https://wordpress.org/support/topic/wordpress-5-6-support/
Guide from the core team https://make.wordpress.org/support/2020/12/handling-potential-jquery-issues-in-wordpress-5-6/
Guide for updating jQuery 3.5 https://jquery.com/upgrade-guide/3.5/ and 3.0 https://jquery.com/upgrade-guide/3.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant