Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #16

Closed
chadcwilliams opened this issue Jul 25, 2023 · 2 comments
Closed

Code cleanup #16

chadcwilliams opened this issue Jul 25, 2023 · 2 comments
Assignees
@chadcwilliams @whyhardt
Labels
gan relevant to gan development priority 0: emergency These can be blockers, or security issues, and should be resolved immediately.
Milestone
EEG-GAN v2.0

Comments

@chadcwilliams
Copy link
Collaborator

EEG-GAN has a history of exploration and development. Lots of different things have been tried, and much of this has been left and is now unused and unsupported.

We need to go through all relevant files and take out anything that is no longer supported.
@chadcwilliams chadcwilliams added priority 1: needed These are highly desirable to be fixed, ideally within 2 weeks. gan relevant to gan development labels Jul 25, 2023
@chadcwilliams chadcwilliams added priority 0: emergency These can be blockers, or security issues, and should be resolved immediately. priority 1: needed These are highly desirable to be fixed, ideally within 2 weeks. and removed priority 1: needed These are highly desirable to be fixed, ideally within 2 weeks. priority 0: emergency These can be blockers, or security issues, and should be resolved immediately. labels Aug 24, 2023
This was referenced Apr 17, 2024
Closed
Closed
@chadcwilliams chadcwilliams added priority 0: emergency These can be blockers, or security issues, and should be resolved immediately. and removed priority 1: needed These are highly desirable to be fixed, ideally within 2 weeks. labels Apr 17, 2024
@chadcwilliams chadcwilliams added this to the EEG-GAN v2.0 milestone Apr 17, 2024
@chadcwilliams
Copy link
Collaborator Author

chadcwilliams commented Apr 22, 2024 •
edited
Loading

Issues to resolve:
List all things we think of to clean up as comments

-Clean unused code
-Load checkpoint works differently between GAN and AE (both the param to do so and how it is done)
-Remove non-TTS GAN structures
-Remove LR scheduler
-Remove channel recovery stuff
-Remove seq2seq
-Remove GAN classifier

@chadcwilliams chadcwilliams mentioned this issue May 28, 2024
Merged
@chadcwilliams
Copy link
Collaborator Author

Completed with #103

We could go through everything again in detail in the future and remove anything else that is unused or unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadcwilliams chadcwilliams

@whyhardt whyhardt

Labels
gan relevant to gan development priority 0: emergency These can be blockers, or security issues, and should be resolved immediately.
Projects
None yet
Milestone
EEG-GAN v2.0
Development

No branches or pull requests
2 participants
@chadcwilliams @whyhardt