Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of sklearn #18

Open
f-brinkmann opened this issue Dec 12, 2023 · 2 comments
Open

Deprecation of sklearn #18

f-brinkmann opened this issue Dec 12, 2023 · 2 comments

Comments

@f-brinkmann
Copy link
Contributor

Your https://github.com/AudioCommons/timbral_models/blob/master/setup.py depends on sklearn, which is now deprecated. The suggested fix is to use scikit-learn instead.

Does someone have the time to try this? For some reason I get an error when trying to clone the repository. The easiest way to try might be

@f-brinkmann
Copy link
Contributor Author

f-brinkmann commented Dec 12, 2023

@Rodsis, @AndyP103, @ffont pull request #17 does this , but it seems to do more than changing setup.py. Maybe a simple pull doing only this could be merged quickly to release a new version of timbral_models. I would consider this a bug and our students are currently having trouble using timbral_models at all.

@gionstegmann
Copy link
Contributor

@f-brinkmann I have created a focused pull request that addresses only the update from sklearn to scikit-learn in the setup.py file. This should ensure compatibility without the additional changes included in pull request #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants