Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the py_str function #7

Open
deontologician opened this issue Sep 3, 2015 · 3 comments
Open

Typo in the py_str function #7

deontologician opened this issue Sep 3, 2015 · 3 comments

Comments

@deontologician
Copy link

Looks like maybe_unstr is defined, but maybe_str is used. In python_tests all exceptions are discarded though, so a few places where there is a valid ot value aren't found by the converter

@deontologician
Copy link
Author

Specifically, I got a difference on these:

regression/4146.yaml test #1
    should be : "{'created': 1}"
    got       : None
regression/3637.yaml test #2
    should be : "{'id': 0.0, 'value': 'abc'}"
    got       : None
regression/3637.yaml test #3
    should be : "{'id': 0.0, 'value': 'abc'}"
    got       : None
meta/table.yaml test #53
    should be : "{'inserted': 4}"
    got       : None
changefeeds/point.yaml test #31
    should be : "{'skipped': 0, 'replaced': 0, 'errors': 0, 'deleted': 0, 'unchanged': 0, 'inserted': 1}"
    got       : None

@AtnNn
Copy link
Owner

AtnNn commented Sep 4, 2015

Does changing maybe_unstr to maybe_str fix the issue?

I don't recognize that output format. Where is it from?

@deontologician
Copy link
Author

The typo is hiding some other bugs. The format is just a comparison I did between the original version and one that fixes that particular issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants