Fixing issue in exclusion of new entities when positions are updated. #1279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances the update of positions is executed before all new entities are persisted. In this case the new entities' identifier is
NULL
, which makes the queryAND n.{$meta->identifier[0]} NOT IN (:excluded)
failing, because xyz NOT IN (NULL) is always false.This patch is addressing the code added in #1214.