refactor functional test to use conditional afterEach #2813
+343
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aporss <[email protected]>
ArtjomsPorss
force-pushed
the
ui-func-test-fixes
branch
from
f3b986b
to
1022ca3
Compare
ArtjomsPorss
changed the title
havetisyan
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor ui functional tests - moved cleanup out of the test into
afterEachstep.afterEachchecks which test was run and executes corresponding cleanup logic.Cannot use
afterstep because these run after execution of all tests in the file and it doesn't help when separate tests test same functionality and require it to be in clean state.Contribution Checklist: