This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Replacing row iteration by chunks with iter_rows
method
#93
Labels
iter_rows
method
#93
In multiple places we use
chunks
iteration where we could use the newiter_rows
anditer_rows_mut
methods.Known places where this exists:
gmm.rs
in theupdate_params
method (onnew_means.mut_data()
).naive_bayes.rs
in theupdate_params
method (ontargets.data()
).naive_bayes.rs
in theget_classes
method (onlog_probs.data()
).In addition to the above there are likely a number of other areas where code can be tidied up using the
iter_rows
methods. One such example:In
svm.rs
, theker_mat
method. Instead of using:We can iterate over the rows in
m1
andm2
and then push the data intoker_data
.There are likely many more examples. The above is a good start.
The text was updated successfully, but these errors were encountered: