You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
With the addition of swap_rows and swap_cols it would be nice if we added a Transformer to shuffle the rows of input data. We should use an algorithm similar to the in_place_fisher_yates in learning/toolkit/rand_utils to do the actual shuffle.
There are a couple ways that we can handle the inv_transform function.
Don't implement it at all and just return an Err, this is really ugly.
Implement it by keeping track of the swaps and doing them in reverse order. Has some memory overhead for a feature that will rarely be needed.
Separate out the traits: pub trait Invertible: Transformer. And don't implement Invertible for Shuffler.
None of these solutions feel all that clean. We could adopt the same approach as DBSCAN and hide the memory overhead behind a flag on the Shuffler struct. This is really ugly but does allow the user to pick the best option for them.
Would be happy to get feedback on these options.
The text was updated successfully, but these errors were encountered:
Note that this is blocked by #117 .
With the addition of
swap_rows
andswap_cols
it would be nice if we added aTransformer
to shuffle the rows of input data. We should use an algorithm similar to thein_place_fisher_yates
inlearning/toolkit/rand_utils
to do the actual shuffle.There are a couple ways that we can handle the
inv_transform
function.Err
, this is really ugly.pub trait Invertible: Transformer
. And don't implementInvertible
forShuffler
.None of these solutions feel all that clean. We could adopt the same approach as
DBSCAN
and hide the memory overhead behind a flag on theShuffler
struct. This is really ugly but does allow the user to pick the best option for them.Would be happy to get feedback on these options.
The text was updated successfully, but these errors were encountered: