Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jj): Add lazyjj #986

Merged
merged 1 commit into from
May 24, 2024
Merged

feat(jj): Add lazyjj #986

merged 1 commit into from
May 24, 2024

Conversation

Cretezy
Copy link
Contributor

@Cretezy Cretezy commented May 24, 2024

📑 Description

  • Adds lazyjj (a TUI for jj, similar to lazygit) mapping

Disclamer: I am the author of lazyjj.

image

Copy link

github-actions bot commented May 24, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Cretezy Cretezy force-pushed the push-prvqlltktkoq branch from 2c13138 to 0d26d02 Compare May 24, 2024 05:24
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a requirement about lazyjj being in path.
Or actually, we should make it an optional dependency. Similar to how lazygit is today.

@Cretezy
Copy link
Contributor Author

Cretezy commented May 24, 2024

@Uzaaft: How should that work? Should it not include the key mapping if lazyjj is not present, or should it show an error when it's executed?

For lazygit, AstroNvim doesn't add the mapping if it's not in the path. I'm inclined to do the same.

@Cretezy Cretezy changed the title feat(jj): Add vim-jjdescription to jj pack feat(jj): Add lazyjj to jj pack May 24, 2024
@Cretezy Cretezy changed the title feat(jj): Add lazyjj to jj pack pack(jj): Add lazyjj May 24, 2024
@Cretezy Cretezy force-pushed the push-prvqlltktkoq branch from 0d26d02 to a4e6a3d Compare May 24, 2024 06:36
@Cretezy Cretezy requested a review from Uzaaft May 24, 2024 06:36
@Uzaaft
Copy link
Member

Uzaaft commented May 24, 2024

That was my point, I should have written it better. Lets go for the same approach as how astronvim does it today with lazygit.

@Uzaaft Uzaaft changed the title pack(jj): Add lazyjj feat(jj): Add lazyjj May 24, 2024
@Uzaaft Uzaaft merged commit a7dfa7b into AstroNvim:main May 24, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants