Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add Lean language pack #957

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented May 12, 2024

📑 Description

This PR adds language support for the Lean theorem prover via the lean.nvim extension.

This is an intentionally trivial PR to get my feet wet with config upstreaming :)

ℹ Additional Information

The lean.nvim plugin explicitly requires an on_attach() callback to be set, so I relied on the astrolsp-provided one.

Copy link

github-actions bot commented May 12, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mehalter mehalter merged commit b90565c into AstroNvim:main May 12, 2024
12 checks passed
@rami3l rami3l deleted the feat/lean-pack branch May 12, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants