Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): Add vim-tabby #904

Merged
merged 16 commits into from
Apr 24, 2024
Merged

feat(completion): Add vim-tabby #904

merged 16 commits into from
Apr 24, 2024

Conversation

PatMulligan
Copy link
Contributor

@PatMulligan PatMulligan commented Apr 21, 2024

Closes #872

📑 Description

Instructions to use Tabby for an open-source, self-hosted AI coding assistant. With Tabby, every team can set up its own LLM-powered code completion server with ease.

  • Install TabbyML/vim-tabby with Lazy
  • Set proper initial config (non-conflicting key-bindings, etc)
  • Clean up README

Additional Information

I added some steps for installing on Linux with Docker as Tabby Docs demonstrate particularly methods for Windows/Mac. However, maybe this is more suited to putting in their repo? Or maybe the user is just expected to figure this out on their own as Docker is agnostic... Let me know what you think

Otherwise, just want to make sure that the key-bindings are appropriate. I assume is likely to be conflicting...

Copy link

github-actions bot commented Apr 21, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments I added.

lua/astrocommunity/completion/tabby-nvim/README.md Outdated Show resolved Hide resolved
lua/astrocommunity/completion/tabby-nvim/README.md Outdated Show resolved Hide resolved
lua/astrocommunity/completion/tabby-nvim/init.lua Outdated Show resolved Hide resolved
@Uzaaft Uzaaft marked this pull request as draft April 21, 2024 09:05
@Uzaaft Uzaaft changed the title WIP initial setup for Tabby completion with open-source LLM's feat(completion): Add vim-tabby Apr 21, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Apr 21, 2024

So the only thing missing is to fix the keybindings. Any proposals?

@Uzaaft
Copy link
Member

Uzaaft commented Apr 22, 2024

I'll add the mapping to astrocore later today.

@Uzaaft Uzaaft self-assigned this Apr 22, 2024
lua/astrocommunity/completion/tabby-nvim/init.lua Outdated Show resolved Hide resolved
Co-authored-by: Micah Halter <[email protected]>
@luxus
Copy link
Member

luxus commented Apr 22, 2024

How does it gets loaded if lazy is true?

@mehalter
Copy link
Member

we don't set lazy = true

@mehalter
Copy link
Member

If the user wants lazy loading then they can add it themselves. Or someone can recommend a good default lazy loading scheme

@luxus
Copy link
Member

luxus commented Apr 22, 2024

yeah sure, but most specs here have some trigger for loading, i guess people would expect it would work if they setup lazy = true
or does event = { "AstroFile" } not make sense in this case?

@mehalter
Copy link
Member

sure we can set that event i don't think it makes a different really

@PatMulligan PatMulligan marked this pull request as ready for review April 23, 2024 00:51
@PatMulligan
Copy link
Contributor Author

PatMulligan commented Apr 23, 2024

with the addition of event = "User AstroFile", the Tabby server seems not to connect for some reason, it stalls at initializing, but can't seem to find any logs. Would this modify the runtimepath in anyway?

@Uzaaft Uzaaft dismissed mehalter’s stale review April 24, 2024 07:15

Not valid anymore

@Uzaaft Uzaaft merged commit 93b0b67 into AstroNvim:main Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ollama tab auto-complete
4 participants