-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(note-taking): Add venn-nvim #901
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
how do you remove mapping. set_mappings seems to only set ? |
I'll handle this :) |
@rameshsanth I modified this implementation a bit to integrate a bit more seamlessly with AstroCore and make the mapping more easily configurable by the user. This also makes it a bit easier to start venn mode by setting up a user command It's also important to note that this plugin's method of setting up the buffer mappings is pretty bad and comes in and clobbers any previous buffer local mappings such as |
@Uzaaft this is ready for review |
Reviewing this soon |
@rameshsanth I actually just added Hydra.nvim to AstroCommunity in a way that it can be integrated with other plugins. I modified this config so that if hydra is available it defines the diagramming mode as a submode in Neovim (As described here: https://github.com/anuvyklack/hydra.nvim/wiki/Draw-diagrams) If you want to try it out simply add hydra from AstroCommunity :) |
Draw ASCII diagrams easily in Neovim
📑 Description
Added new plugin with necessary configuration per the author
ℹ Additional Information