Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp_lines.nvim no longer disables diagnostic virtual text #825

Closed
3 tasks done
ddiazghub opened this issue Apr 3, 2024 · 1 comment · Fixed by #826
Closed
3 tasks done

lsp_lines.nvim no longer disables diagnostic virtual text #825

ddiazghub opened this issue Apr 3, 2024 · 1 comment · Fixed by #826
Labels
bug Something isn't working

Comments

@ddiazghub
Copy link

Checklist

  • I have searched through the AstroNvim docs
  • I have searched through the existing issues of AstroNvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.5 release

Operating system/version

macOS 14.2.1

Terminal/GUI

kitty

Describe the bug

Hello, I just wanted to report a very minor bug I noticed since v4 released. For some reason lsp_lines astrocommunity package no longer disables virtual text diagnostics automatically.

I solved it by adding the following line to polish.lua, however it might still be something that you want to look at.

image

Steps to Reproduce

  1. Add the lsp_lines plugin through community.lua:
    image
  2. Restart neovim.
  3. Induce an error in your code, virtual text will be enabled and diagnostics will be duplicated.
    image

Expected behavior

Virtual text diagnostics shouldn't be visible, this is the same code after applying the aforementioned fix:
image

Screenshots

No response

Additional Context

No response

@luxus
Copy link
Member

luxus commented Apr 4, 2024

thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants