Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(harpoon): Update to v2 #741

Merged
merged 2 commits into from
Feb 12, 2024
Merged

feat(harpoon): Update to v2 #741

merged 2 commits into from
Feb 12, 2024

Conversation

luxus
Copy link
Member

@luxus luxus commented Jan 29, 2024

tested with minimal v3 install.. but not actually using it. so i hope it works :D

Copy link

github-actions bot commented Jan 29, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft linked an issue Jan 29, 2024 that may be closed by this pull request
@Uzaaft Uzaaft changed the title fix(harpoon): Update to v2 feat(harpoon): Update to v2 Jan 29, 2024
@luxus luxus marked this pull request as ready for review February 11, 2024 18:18
@luxus luxus requested a review from a team February 11, 2024 18:18
@luxus
Copy link
Member Author

luxus commented Feb 12, 2024

it should work now

@Uzaaft
Copy link
Member

Uzaaft commented Feb 12, 2024

@luxus I’ll take a look in about 1h. 👀

@Uzaaft Uzaaft merged commit ee84769 into main Feb 12, 2024
12 checks passed
@Uzaaft Uzaaft deleted the luxus-harpoonv2 branch February 12, 2024 15:20
@mehalter
Copy link
Member

This was incorrectly not marked as a breaking change

@mehalter
Copy link
Member

just a heads up. I will revise the commit now before we tag a release

mehalter pushed a commit that referenced this pull request Feb 15, 2024
* feat(harpoon): Update to v2 branch

* fix(harpoon): Remove invalid cmd table

---------

Co-authored-by: Uzair Aftab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Harpoon 2
3 participants