Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Handle docker-compose.yaml filetype to make lsp attach #715

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jan 11, 2024

No description provided.

Copy link

github-actions bot commented Jan 11, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft linked an issue Jan 11, 2024 that may be closed by this pull request
3 tasks
@Uzaaft Uzaaft changed the title feat(docker): Add filetype handling to pack to make lsp attach feat(docker): Handle docker-compose.yaml filetype to make lsp attach Jan 12, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Uzaaft Uzaaft merged commit 8e964d3 into main Jan 12, 2024
16 checks passed
@Uzaaft Uzaaft deleted the fix/docker branch January 12, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(pack): Docker not works in docker-compose.yml.
2 participants