Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swift): mv to swift only support (no xcode tooling here) #670

Merged
merged 3 commits into from
Dec 5, 2023
Merged

feat(swift): mv to swift only support (no xcode tooling here) #670

merged 3 commits into from
Dec 5, 2023

Conversation

andreacfromtheapp
Copy link
Contributor

📑 Description

Moving away from any XCode tooling in Swift Lang pack. See: #669 (comment)

ℹ Additional Information

I am aware that opinionated is against the Astrocommunity guidelines. However, this pack has to be opinionated to make any sense. Otherwise the only thing in it would be treesitter. Not much to offer, really.

While not standardized (not for lack of trying), SwiftLint and SwiftFormat (not the Apple one) appear to be widely accepted by the community. They offer great customization too, in their own .dotfiles and it's an approach widely used by the community.

I'd say that until Apple (or the community) sets on a standard, this is the best we could do.

Copy link

github-actions bot commented Dec 4, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@andreacfromtheapp
Copy link
Contributor Author

damn I just realized it is not working. I tested it, but I forgot to remove my own configs first. My apologies. I'm on a fix.

@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Dec 5, 2023

not sure it is the proper way, but this seems to work fine, and I pushed it.

local utils = require "astronvim.utils"

return {
  {
    "nvim-treesitter/nvim-treesitter",
    opts = function(_, opts)
      if opts.ensure_installed ~= "all" then
        opts.ensure_installed = utils.list_insert_unique(opts.ensure_installed, "swift")
      end
    end,
  },
  {
    "williamboman/mason-lspconfig.nvim",
    init = function() require("astronvim.utils.lsp").setup "sourcekit" end,
  },
}

@andreacfromtheapp
Copy link
Contributor Author

resolves #669

@Uzaaft
Copy link
Member

Uzaaft commented Dec 5, 2023

@gacallea Added back codelldb.

@andreacfromtheapp
Copy link
Contributor Author

@gacallea Added back codelldb.

my bad. I thought it wasn't part of "basic" support. Good call.

@Uzaaft Uzaaft merged commit cfe5e3f into AstroNvim:main Dec 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants