Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(note-taking): add support for zettelkasten with zk-nvim #654

Merged
merged 5 commits into from
Nov 27, 2023
Merged

feat(note-taking): add support for zettelkasten with zk-nvim #654

merged 5 commits into from
Nov 27, 2023

Conversation

andreacfromtheapp
Copy link
Contributor

📑 Description

Adding support for zk-nvim.

ℹ Additional Information

All about Zettelkasten here: https://zettelkasten.de/posts/overview/

Copy link

github-actions bot commented Nov 26, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin spec seems alright, please take a look at the changes I suggest for the docs

lua/astrocommunity/note-taking/zk-nvim/README.md Outdated Show resolved Hide resolved
@andreacfromtheapp
Copy link
Contributor Author

@Uzaaft sorry about the opts = {} missing and the style mishaps.

@Uzaaft
Copy link
Member

Uzaaft commented Nov 27, 2023

@Uzaaft sorry about the opts = {} missing and the style mishaps.

I believe I fucked up the style 🤣

@Uzaaft Uzaaft merged commit 22b24e7 into AstroNvim:main Nov 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants