Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Swap out eslint_d with eslint-lsp #600

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Oct 8, 2023

Closes #593 .
Partiallly solves #590
To change and use this branch, add:

{
 "AstroNvim/astrocommunity",
branch = "eslint-lsp",
...
}

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Infonautica
Copy link
Contributor

Infonautica commented Oct 8, 2023

From a brief testing everything works good and as expected 👌
But i'll try it out more during the week

@Infonautica
Copy link
Contributor

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 9, 2023

Please update Readme file for the pack as well: main/lua/astrocommunity/pack/typescript/README.md

Will do it, if we decide to go forward with eslint-lsp :)

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 10, 2023

@mehalter I see that the dap file is named as deno. Can I include a path for that here, or should that be a seperate PR?
image

@Infonautica
Copy link
Contributor

@Uzaaft I've been using this branch for 3 days straight and have not encountered any issues so far 👍

@mehalter
Copy link
Member

@mehalter I see that the dap file is named as deno. Can I include a path for that here, or should that be a seperate PR?

I think you can do that here no problem @Uzaaft !

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Uzaaft Uzaaft requested a review from mehalter October 11, 2023 17:09
@mehalter mehalter merged commit 54a0988 into main Oct 11, 2023
10 checks passed
@mehalter mehalter deleted the eslint-lsp branch October 11, 2023 17:19
@tofulm
Copy link

tofulm commented Oct 12, 2023

since the update, I get this error : [lspconfig] Unable to find ESLint library.

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 12, 2023

Make sure eslint is in the project

@tofulm
Copy link

tofulm commented Oct 12, 2023

eslint is installed globally. I had to install it in my project, and it's ok
Is it possible to configure to use eslint global

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 12, 2023

eslint is installed globally. I had to install it in my project, and it's ok Is it possible to configure to use eslint global

Read the docs here: https://github.com/microsoft/vscode-eslint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-lsp over eslint_d in the typescript pack
4 participants