-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript): Swap out eslint_d with eslint-lsp #600
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
From a brief testing everything works good and as expected 👌 |
Please update Readme file for the pack as well: |
Will do it, if we decide to go forward with eslint-lsp :) |
@mehalter I see that the dap file is named as deno. Can I include a path for that here, or should that be a seperate PR? |
@Uzaaft I've been using this branch for 3 days straight and have not encountered any issues so far 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
since the update, I get this error : |
Make sure eslint is in the project |
eslint is installed globally. I had to install it in my project, and it's ok |
Read the docs here: https://github.com/microsoft/vscode-eslint |
Closes #593 .
Partiallly solves #590
To change and use this branch, add: