Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vim-illuminate)!: rename plugin to follow convention #443

Merged
merged 1 commit into from
Jul 15, 2023
Merged

fix(vim-illuminate)!: rename plugin to follow convention #443

merged 1 commit into from
Jul 15, 2023

Conversation

TheSast
Copy link
Contributor

@TheSast TheSast commented Jul 15, 2023

Should breaking changes only be considered such if they break compared to a previous releases?

@github-actions
Copy link

github-actions bot commented Jul 15, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the mistake 😅

@Uzaaft
Copy link
Member

Uzaaft commented Jul 15, 2023

Makes sense to mark this one as breaking @TheSast . Thanks for catching the mistake!!

@Uzaaft Uzaaft merged commit 79935f0 into AstroNvim:main Jul 15, 2023
@TheSast TheSast deleted the vim-illuminate branch July 15, 2023 11:54
mehalter pushed a commit that referenced this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants