Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neotest): add neodev integration #437

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix(neotest): add neodev integration #437

merged 2 commits into from
Jul 14, 2023

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jul 14, 2023

Should fix #406

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft requested a review from mehalter July 14, 2023 10:37
lua/astrocommunity/test/neotest/init.lua Outdated Show resolved Hide resolved
Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@owittek owittek merged commit 6e8c699 into main Jul 14, 2023
@owittek owittek deleted the neodev-neotest branch July 14, 2023 10:49
@Uzaaft
Copy link
Member Author

Uzaaft commented Jul 14, 2023

@owittek While your changes seemed correct, I'm not sure they are? neotest seems broken now for me

@owittek
Copy link
Member

owittek commented Jul 14, 2023

@owittek While your changes seemed correct, I'm not sure they are? neotest seems broken now for me

Sounds odd as both versions should work the exact same way. Could you confirm that the issue is related to this line?

@khaneliman
Copy link
Contributor

khaneliman commented Jul 14, 2023

@Uzaaft @owittek After updating my plugins I get this.

`Failed to run `config` for neodev.nvim

.../astrocommunity/lua/astrocommunity/test/neotest/init.lua:11: attempt to index field 'library' (a nil value)

# stacktrace:
  - /astrocommunity/lua/astrocommunity/test/neotest/init.lua:11 _in_ **values**
  - ~/.config/nvim/lua/astronvim/utils/lsp.lua:404 _in_ **config**
  - ~/.config/nvim/lua/astronvim/utils/lsp.lua:86 _in_ **setup**
  - ~/.config/nvim/lua/plugins/lsp.lua:45
  - /mason-lspconfig.nvim/lua/mason-lspconfig/init.lua:84 _in_ **fn**
  - /mason.nvim/lua/mason-core/optional.lua:101 _in_ **if_present**
  - /mason-lspconfig.nvim/lua/mason-lspconfig/init.lua:82 _in_ **fn**
  - /mason.nvim/lua/mason-core/functional/list.lua:98 _in_ **each**
  - /mason-lspconfig.nvim/lua/mason-lspconfig/init.lua:92 _in_ **setup_handlers**
  - /mason-lspconfig.nvim/lua/mason-lspconfig/init.lua:50 _in_ **setup**
  - ~/.config/nvim/lua/plugins/configs/mason-lspconfig.lua:2 _in_ **config**
  - ~/.config/nvim/lua/astronvim/utils/init.lua:144

@Uzaaft
Copy link
Member Author

Uzaaft commented Jul 14, 2023

@khaneliman I'm on it. :)

mehalter pushed a commit that referenced this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add neodev integration for neotest community pack
3 participants