Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(octo-nvim): which-key description and color for nested entries #419

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

RayJameson
Copy link
Contributor

@RayJameson RayJameson commented Jul 13, 2023

Yet another one of like #376 and what after it. Also, remove default mappings which the plugin sets, to avoid keymap mess

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@RayJameson RayJameson force-pushed the fix/octo/which-key branch from c148ab1 to 3280fda Compare July 13, 2023 03:52
@RayJameson RayJameson changed the title fix(octo): which-key description and color for nested entries fix(octo-nvim): which-key description and color for nested entries Jul 13, 2023
@RayJameson RayJameson marked this pull request as ready for review July 13, 2023 03:54
@RayJameson RayJameson force-pushed the fix/octo/which-key branch from 3280fda to 783fcb5 Compare July 13, 2023 04:18
@RayJameson RayJameson force-pushed the fix/octo/which-key branch from 783fcb5 to fbaf4e3 Compare July 13, 2023 04:19
@TheSast
Copy link
Contributor

TheSast commented Jul 13, 2023

Did you mean: "Make which-key entries color blue, as they should be" ?

Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owittek owittek merged commit 556e253 into AstroNvim:main Jul 13, 2023
@RayJameson RayJameson deleted the fix/octo/which-key branch July 13, 2023 08:39
@RayJameson
Copy link
Contributor Author

Did you mean: "Make which-key entries color blue, as they should be" ?

yea, my bad :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants