Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refactoring-nvim): improve lazy loading #382

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Subjective
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owittek
Copy link
Member

owittek commented Jul 7, 2023

Ah, almost missed it! Please edit the commit message to use the proper scope: fix(editing-support)

@Subjective
Copy link
Contributor Author

Wait shouldn't it be fix(refactoring-nvim) as per the Review Checklist?

If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

@Subjective Subjective changed the title fix(refactoring): improve lazy loading fix(refactoring-nvim): improve lazy loading Jul 7, 2023
@owittek
Copy link
Member

owittek commented Jul 7, 2023

Wait shouldn't it be fix(refactoring-nvim) as per the Review Checklist?

If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

Actually you're right, not sure why the pipeline failed before. And I am too sleepy to tell that it wasn't an error on your side. Sorry!

@owittek owittek merged commit e26c734 into AstroNvim:main Jul 7, 2023
@Subjective
Copy link
Contributor Author

Oh no, it's because I just changed the name of the PR, it was actually just fix(refactoring) before

@Subjective Subjective deleted the patch-7 branch July 18, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants