feat(pack): Adding ansible pack

[Sacro]

No description provided.

[github-actions]

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

• If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

• If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

• Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

• README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

• Proper usage of opts table rather than setting things up with the config function.

[Sacro]

Should be better now!

[mehalter]

We should probably also add the filetype.add to this pack:

local function yaml_ft(path, bufnr)
    -- get content of buffer as string
    local content = vim.filetype.getlines(bufnr)
    if type(content) == "table" then content = table.concat(content, "\n") end

    -- check if file is in roles, tasks, or handlers folder
    local path_regex = vim.regex "(tasks\\|roles\\|handlers)/"
    if path_regex and path_regex:match_str(path) then return "yaml.ansible" end
    -- check for known ansible playbook text and if found, return yaml.ansible
    local regex = vim.regex "hosts:\\|tasks:"
    if regex and regex:match_str(content) then return "yaml.ansible" end

    -- return yaml if nothing else
    return "yaml"
  end

  vim.filetype.add {
    extension = {
      yml = yaml_ft,
      yaml = yaml_ft,
    },
  }

[Sacro]

Looks good, do you want me to add that?

…

On Sun, 2 Jul 2023, 11:56 Micah Halter, ***@***.***> wrote: We should probably also add the filetype.add to this pack: local function yaml_ft(path, bufnr) -- get content of buffer as string local content = vim.filetype.getlines(bufnr) if type(content) == "table" then content = table.concat(content, "\n") end -- check if file is in roles, tasks, or handlers folder local path_regex = vim.regex "(tasks\\|roles\\|handlers)/" if path_regex and path_regex:match_str(path) then return "yaml.ansible" end -- check for known ansible playbook text and if found, return yaml.ansible local regex = vim.regex "hosts:\\|tasks:" if regex and regex:match_str(content) then return "yaml.ansible" end -- return yaml if nothing else return "yaml" end vim.filetype.add { extension = { yml = yaml_ft, yaml = yaml_ft, }, } — Reply to this email directly, view it on GitHub <#346 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUJMHPQ7GW4OLVMEF2EEGDXOFHVDANCNFSM6AAAAAAZ3BWLYI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mehalter]

Oh wait, does ansible-vim already add this? This might not be necessary

[Sacro]

It does, but it's not lazy loaded unless you manually set the filetype first. if we can trigger that automagically that would be nice.

[mehalter]

@Sacro if we set the filetype and are using language servers and treesitter, does ansible-vim even provide anything else? I think it just provides syntax highlighting and filetype detector which are all handled elsewhere

[Sacro]

I find I'm getting better code completion with it enabled.

…

On Sun, 2 Jul 2023, 14:34 Micah Halter, ***@***.***> wrote: @Sacro <https://github.com/Sacro> if we set the filetype and are using language servers and treesitter, does ansible-vim even provide anything else? I think it just provides syntax highlighting and filetype detector which are all handled elsewhere — Reply to this email directly, view it on GitHub <#346 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUJMHLJANTNQ7JMLEN5QH3XOF2GZANCNFSM6AAAAAAZ3BWLYI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mehalter]

This looks awesome thanks!