Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change olexsmir/gopher.nvim to ray-x/go.nvim #325

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

ypli0629
Copy link
Contributor

ray-x/go.nvim provide more powerful functions

@Uzaaft Uzaaft requested a review from luxus June 28, 2023 14:24
@Uzaaft
Copy link
Member

Uzaaft commented Jun 28, 2023

@luxus Go is your domain.
@AstroNvim/astrocommunity-maintainers Shouldn't this PR be marked as a breaking change?

@mehalter
Copy link
Member

@Uzaaft I think for the case of the AstroCommunity repository we should consider breaking changes as changes to the API. So if the name of the pack/plugin entry doesn't change, paths, etc. then it shouldn't be considered breaking

@Uzaaft
Copy link
Member

Uzaaft commented Jun 28, 2023

@mehalter While I agree, doesn't the change of available commands in Neovim for Go constitute an breaking change?

@mehalter
Copy link
Member

I think for the case of AstroCommunity the things the plugins provide should be considered outside of the scope of our API

@Uzaaft
Copy link
Member

Uzaaft commented Jun 29, 2023

I'll take a look at this in a couple of hours just to make sure it works as expected. Sorry about the delay in merging @ypli0629

@luxus
Copy link
Member

luxus commented Jun 29, 2023

Not sure about x-rayz plugins…
Most plugins are a bit messy

didn’t have a go project right now to test it

@Uzaaft
Copy link
Member

Uzaaft commented Jun 29, 2023

LGTM.
go.nvim seems to me more used, so the change makes sense.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants