Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editing-support): add ultimate-autopair.nvim #314

Merged
merged 5 commits into from
Jun 30, 2023
Merged

feat(editing-support): add ultimate-autopair.nvim #314

merged 5 commits into from
Jun 30, 2023

Conversation

windowsrefund
Copy link
Contributor

No description provided.

@windowsrefund windowsrefund mentioned this pull request Jun 25, 2023
Closed
@Uzaaft
Copy link
Member

Uzaaft commented Jun 25, 2023

@windowsrefund I think the opts should be empty, unless there's a reason why you're setting changing them.

@Uzaaft Uzaaft added the question Further information is requested label Jun 29, 2023
mehalter
mehalter requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go ahead and merge this once we update the lazy loading to event rather than off.

@Uzaaft the options they are using look like pretty good defaults and they linked issues to the "why" as well

mehalter
mehalter requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this README.md file should be in the utlimate-autopair-nvim folder also can you make the format follow the same as other plugins? This looks like it's more following the format of the README for packs

mehalter
mehalter approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 73a537c into AstroNvim:main Jun 30, 2023
@mehalter mehalter mentioned this pull request Jun 30, 2023
Merged
Uzaaft pushed a commit that referenced this pull request Jul 1, 2023
@windowsrefund @Uzaaft
feat(editing-support): add ultimate-autopair.nvim (#314)
87629e4 
* feat(editing-support): add ultimate-autopair.nvim

* load on event

* move readme

---------

Co-authored-by: windowsrefund <mtf8>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxus luxus luxus left review comments

@mehalter mehalter mehalter approved these changes

Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@windowsrefund @Uzaaft @luxus @mehalter