Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-runner): add compiler.nvim #298

Merged
merged 3 commits into from
Jun 22, 2023
Merged

feat(code-runner): add compiler.nvim #298

merged 3 commits into from
Jun 22, 2023

Conversation

Zeioth
Copy link
Contributor

@Zeioth Zeioth commented Jun 21, 2023

More info about the project can be found here: https://github.com/Zeioth/Compiler.nvim

@luxus
Copy link
Member

luxus commented Jun 21, 2023

so its depends on overseer?

@luxus luxus requested a review from a team June 21, 2023 22:07
@Uzaaft
Copy link
Member

Uzaaft commented Jun 21, 2023

Can you fix the way you import your repo? Other repositories doesn’t seem to need the whole git url

@Zeioth
Copy link
Contributor Author

Zeioth commented Jun 22, 2023

@luxus yes, we use it to run the calls because it fits 100% the case of use. To some degree, Compiler.nvim is to overseer what friendly snippets is to luasnip, you could say.

@uza thank you for that, missed it. I've cleaned up that, and the comments too.

@Uzaaft
Copy link
Member

Uzaaft commented Jun 22, 2023

Can you fix the Invalid PR title, and we'll be ready to merge 🫡

@owittek
Copy link
Member

owittek commented Jun 22, 2023

Might also want to move the Overseer config inside of the dependencies table.

@mehalter mehalter changed the title feat(compiler.nvim) feat(code-runner): add compiler.nvim Jun 22, 2023
@mehalter mehalter merged commit fbe19e3 into AstroNvim:main Jun 22, 2023
mehalter added a commit that referenced this pull request Jun 22, 2023
* feat(compiler.nvim)

* Update compiler-nvim.lua

* simplify implementation

---------

Co-authored-by: Micah Halter <[email protected]>
@mehalter
Copy link
Member

I went ahead and cleaned this up and merged it in. Thanks for the contribution @Zeioth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants