Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion)!: separate flit.nvim from leap.nvim #281

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Conversation

owittek
Copy link
Member

@owittek owittek commented Jun 17, 2023

This change has the benefit that only one of those plugins is active instead of both reserving keybinds

@owittek owittek requested a review from a team June 17, 2023 15:14
@Uzaaft
Copy link
Member

Uzaaft commented Jun 17, 2023

Sensible changes. But wouldn't this be a breaking change? @owittek

@owittek
Copy link
Member Author

owittek commented Jun 17, 2023

Sensible changes. But wouldn't this be a breaking change? @owittek

Yes that was my initial thought too but considering that leap.nvim is now actually just leap.nvim I think it might be fine to not actually declare this as breaking.

@Uzaaft
Copy link
Member

Uzaaft commented Jun 17, 2023

Hmm but it changes the previously expected behaviour, no?

@owittek
Copy link
Member Author

owittek commented Jun 17, 2023

I guess so, let me change it to breaking then

This change has the benefit that only one of those plugins is active instead of both reserving keybinds
@owittek owittek changed the title feat(motion): separate flit.nvim from leap.nvim feat(motion)!: separate flit.nvim from leap.nvim Jun 17, 2023
@luxus
Copy link
Member

luxus commented Jun 17, 2023

i guess we need a good commit message, dunno if its understandable that people need to add flit.nvim separately now

@owittek
Copy link
Member Author

owittek commented Jun 17, 2023

i guess we need a good commit message, dunno if its understandable that people need to add flit.nvim separately now

I would just hope for people to look into the commit if a breaking change message pops up. Not sure how to make the message clearer without writing multiple sentences

@mehalter
Copy link
Member

I think the message is fine

@luxus luxus merged commit dcaf64c into AstroNvim:main Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants