-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack): adds angular pack #254
Conversation
I don't think so. I remember mehalter voting against it whenever @owittek did it in the deno pack. |
I actually do the same with the all-in-one pack and since Angular is made for Node I think it's fine to depend on the default ts-pack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We just need to mention the angular treesitter plugin that gets installed. Is that a dependency for treesitter?
We might want to switch the branch for the plugin as described here: nvim-treesitter/nvim-treesitter-angular#4 (comment) |
@mehalter The angular treesitter parser isn't available via
@owittek I wasn't aware of this branch. Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owittek do you mean |
I can do the refactor on Monday |
I already replied on discord but I meant the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor to use the html-css base pack
|
||
- Adds [tsserver pack](https://github.com/AstroNvim/astrocommunity/tree/main/lua/astrocommunity/pack/typescript) | ||
- Adds `[nvim-treesitter-angular](https://github.com/elgiano/nvim-treesitter-angular)` for `angular` Treesitter parser | ||
- Adds `html` and `css` Treesitter parsers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Adds `html` and `css` Treesitter parsers | |
- Adds [HTML & CSS support](../html-css) |
{ | ||
import = "astrocommunity.pack.typescript", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
import = "astrocommunity.pack.typescript", | |
}, | |
{ import = "astrocommunity.pack.html-css" }, | |
{ import = "astrocommunity.pack.typescript" }, |
{ | ||
"nvim-treesitter/nvim-treesitter", | ||
opts = function(_, opts) | ||
if opts.ensure_installed ~= "all" then | ||
opts.ensure_installed = utils.list_insert_unique(opts.ensure_installed, { "html", "css" }) | ||
end | ||
end, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"nvim-treesitter/nvim-treesitter", | |
opts = function(_, opts) | |
if opts.ensure_installed ~= "all" then | |
opts.ensure_installed = utils.list_insert_unique(opts.ensure_installed, { "html", "css" }) | |
end | |
end, | |
}, |
opts = function(_, opts) | ||
opts.ensure_installed = utils.list_insert_unique(opts.ensure_installed, { "angularls", "html", "cssls" }) | ||
end, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opts = function(_, opts) | |
opts.ensure_installed = utils.list_insert_unique(opts.ensure_installed, { "angularls", "html", "cssls" }) | |
end, | |
opts = function(_, opts) opts.ensure_installed = utils.list_insert_unique(opts.ensure_installed, "angularls") end, |
0aeb7d2
to
b59a7aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a refactor to move to using the html-css
pack and also moved the elgiano/nvim-treesitter-angular
to be a dependency of nvim-treesitter
. Have tested locally and looks good to go! Thanks @axelcalixte !
Co-authored-by: Axel Calixte <[email protected]>
Hello,
I noticed there wasn't any pack for Angular so I made one for myself.
Maybe it is useful to someone else.