-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(colorscheme)!: rename colorshemes to guidelines #243
Conversation
They can be in either location for GitHub. In this case we put them front and center so people see them 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
This change should probably be mentioned somewhere in the README. If I didn't run into this PR I wouldn't know I had to change |
@mehalter if these do get added to a README or a release note, we should probably fix all the plugins not following the convention, not just the colorschemes. Also, do you think the version number should be bumped up after everything is renamed? |
@TheSast this was decided it wasn't a breaking change genuinely based on the fact that this should have never been like this in the first place. If people want me to change this to a breaking change we can definitely do that |
@TheSast I do think all plugins get fixed. If you know of more please open a PR to fix them :) |
@TheSast i updated the commit message to show breaking |
Awesome user experience! Break everyone's themes from community overnight! |
Thanks @benjaminmordaunt ! ❤️ |
I'm not a big fan of the big fan of the change, but nobody thought that astrocommunity gets so big.. |
Yeah I agree, also for people who rely on stability can track stable releases with semantic versioning to avoid random breaking changes on updates. Maybe we should just do a full refactor out to remove categories and go to a user/repo structure to completely avoid this issue in the future |
not sure it makes sense.. there are some plugins that are actually 2 and maybe not a pack.. and packs are out of that anyways.. |
Yeah that's true, good ol' Chesterton's fence at play. It's a shame that there are so many conflicts, but the current approach is pretty good/decent. We just have to make sure it is followed to avoid changing our minds down the line like how we got to this point. Definitely tough problem to solve |
Suggested in #242 (review)
Unrelated:
Shouldn't: README.md and CONTRIBUTING.md be in .github 🤔