Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): added docker pack #193

Merged
merged 5 commits into from
May 9, 2023
Merged

Conversation

Souravpakhira
Copy link
Contributor

Created docker folder inside pack. Added dockerfile-language-server and docker-compose-language-service language servers for LSP and hadolint for linting support of dockerfile and docker-compose file.

@mehalter mehalter changed the title feat: added docker pack feat(pack): added docker pack May 9, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion to fix a bug. You should also add dockerfile to the ensure installation for nvim-treesitter:

  {
    "nvim-treesitter/nvim-treesitter",
    opts = function(_, opts)
      if opts.ensure_installed ~= "all" then
        opts.ensure_installed = utils.list_insert_unique(opts.ensure_installed, "dockerfile")
      end
    end,
  },

lua/astrocommunity/pack/docker/docker.lua Outdated Show resolved Hide resolved
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the README update this looks perfect! Thanks so much for the contribution!

lua/astrocommunity/pack/docker/README.md Show resolved Hide resolved
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!!

@mehalter mehalter merged commit f074d56 into AstroNvim:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants