fix(go): install missing goimports

[mehalter]

📑 Description

This supersedes #1162. gopls uses gofumpt for formatting so we can leverage that after running goimports

ℹ Additional Information

[github-actions]

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

• If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

• If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

• Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

• README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

• Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

• Proper usage of opts table rather than setting things up with the config function.

• Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

[Uzaaft]

Fixes mistake done in #1059 I think?

[mehalter]

Yup!

[pgr0ss]

Don't you still need to install gofumpt via mason-tool-installer? In my local testing, it didn't run gofumpt until I added this:

  {
    "WhoIsSethDaniel/mason-tool-installer.nvim",
    opts = function(_, opts)
      opts.ensure_installed = require("astrocore").list_insert_unique(opts.ensure_installed, { "gofumpt" })
    end,
  },

[mehalter]

It doesn't need to, it uses gopls for formatting since that has gofumpt built in

[mehalter]

https://github.com/golang/tools/blob/master/gopls/doc/features/transformation.md#formatting

[pgr0ss]

Hmm, I'm not sure why mine didn't work until I installed it, then. I will look into it. Thanks.

[mehalter]

I can take a look in a bit, but gopls should be formatting after goimports 😅

[mehalter]

Just tested @pgr0ss and it works great! no gofumpt necessary :D gopls handles the formatting itself

[pgr0ss]

@mehalter Do we need to add gofumpt = true to the gopls config, then? This says the default is false:

https://github.com/golang/tools/blob/master/gopls/doc/settings.md#gofumpt-bool

When I added gofumpt = true here it started working for me:

astrocommunity/lua/astrocommunity/pack/go/init.lua

Lines 11 to 51 in 76f4f81

	gopls = {
	analyses = {
	ST1003 = true,
	fieldalignment = false,
	fillreturns = true,
	nilness = true,
	nonewvars = true,
	shadow = true,
	undeclaredname = true,
	unreachable = true,
	unusedparams = true,
	unusedwrite = true,
	useany = true,
	},
	codelenses = {
	gc_details = true, -- Show a code lens toggling the display of gc's choices.
	generate = true, -- show the `go generate` lens.
	regenerate_cgo = true,
	test = true,
	tidy = true,
	upgrade_dependency = true,
	vendor = true,
	},
	hints = {
	assignVariableTypes = true,
	compositeLiteralFields = true,
	compositeLiteralTypes = true,
	constantValues = true,
	functionTypeParameters = true,
	parameterNames = true,
	rangeVariableTypes = true,
	},
	buildFlags = { "-tags", "integration" },
	completeUnimported = true,
	diagnosticsDelay = "500ms",
	matcher = "Fuzzy",
	semanticTokens = true,
	staticcheck = true,
	symbolMatcher = "fuzzy",
	usePlaceholders = true,
	},

[mehalter]

oh yeah maybe! I see, without it it's just running go fmt. Yup that would be a great addition. One second and I'll add it