feat(pack): switch to codelldb for rust debugging #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalter
requested changes
Mar 28, 2023
|
Just out of stylistic preference I would say that local package_path = require("mason-registry").get_package("codelldb"):get_install_path()Is "better practice" than accessing the actual index. Not sure if anyone else has any thoughts on this. (@mehalter ??) |
mehalter
requested changes
Mar 29, 2023
mehalter
changed the title
Co-authored-by: Micah Halter <[email protected]>
Co-authored-by: Oli <[email protected]>
mehalter
approved these changes
Mar 29, 2023
|
Github actions are currently down so I'm just going to merge this anyway. |
|
How should this work on windows? - do we want or
for liblldb_path |
I believe you would want |
|
it does support windows - I use it on windows |
owittek
added a commit
to owittek/astrocommunity
that referenced
this pull request
Apr 4, 2023
* feat!: switch to codelldb for rust debugging * fix: use mason's API for installation path * fix: cleaner use of the mason api Co-authored-by: Micah Halter <[email protected]> * refactor: clean up code a bit Co-authored-by: Oli <[email protected]> --------- Co-authored-by: Micah Halter <[email protected]> Co-authored-by: Oli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up rust-tools to debug with codelldb from Mason instead of lldb-vscode from the system.
Closes #84.