Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not make dash lines for houses #40

Open
afucher opened this issue Feb 21, 2023 · 2 comments
Open

Add option to not make dash lines for houses #40

afucher opened this issue Feb 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@afucher
Copy link
Contributor

afucher commented Feb 21, 2023

Describe the bug
The #25 PR introduce a breaking behavior, since it will draw the lines from the houses without consider the planets/points. In some configuration it makes harder to see the symbol with the line of the house behind it.

I'll revert the changes in the v2 and v3, but opening this issue to check how can we handle the wanted behavior from the #25 . Probably we can add a setting to the v3, to avoid make a dash line.

Screenshots
See #25

@afucher afucher added the enhancement New feature or request label Feb 21, 2023
@ilyai
Copy link
Contributor

ilyai commented Feb 22, 2023

Hi @afucher,
I still didn't get why it was a breaking behavior and how it could cause any issue. Could you show an example please?

@afucher
Copy link
Contributor Author

afucher commented Feb 23, 2023

Sure @ilyai ! Changing the drawing order, makes the line of the houses be always drawn, and when it passes by a symbol it make it harder to see. And this could be worst in small devices, or when it cross the letter that indicates the dignities of the planet (like "r", "e", etc...)
Adding an image from the doc that I'm creating, is not the worst case, but take a look to mercury
Captura de Tela 2023-02-22 às 22 31 36

So, this should be an opt-in behavior, so the dev can turn it on or off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants