-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with header keywords #305
Comments
I'll quickly summarize some of my findings about the WCS in this context:
Maybe it would be possible to also store the sky WCS from the FOVs when they're added to the ImagePlane, then they would be available in the header afterwards and could be written to the output. |
Adding to that so it's written down somewhere: The FOVs' WCSs cannot be used directly for the output WCS, as they generally don't match the whole detector's FOV... Need to find a smarter solution |
Ultimately it would perhaps be best to put all headers in FitsKeywords Effects, which is then included by default. But at least for now it is easier to keep
write_header()
, clean it up so it contains only headers we always want (mostly WCS), and call it always before calling the FitsKeyword effects.The plan:
I realize now that we should check whether the existing keyword effects are suitable enough as a default. As in, we don't want to break too many workflows of people; maybe for some information, like filter selection, we should do something sensible as default.
We decided we can merge this PR without doing all of the above, because we have a plan, and merging this PR will only affect METIS.
Originally posted by @hugobuddel in AstarVienna/irdb#146 (comment)
The text was updated successfully, but these errors were encountered: