Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch release process to aspublish #1519

Merged
merged 9 commits into from
Oct 25, 2020
Merged

Switch release process to aspublish #1519

merged 9 commits into from
Oct 25, 2020

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Oct 25, 2020

Retires semantic-release, which unfortunately is broken for us currently, and uses aspublish.

Aspublish is essentially a minimal replacement for what semantic-release was doing for us, but it only does what typical AS packages need (changelog -> GitHub release -> npm package) in what's essentially a single file with a couple functions, so if there are release issues in the future, we can easily fix these ourselves. Also gets rid of ~5700 lines of package-lock.json and relieves me from maintaining a fork of semantic-release due to my suggestion to handle versions less than 1.0.0 without upping to 1.0.0 being rejected.

What we are losing is bot comments on issues and PRs included in a release, which was a nice touch for contributors, but not so much for maintainers due to having to click through all of them in the morning to see if there are any human comments in between. Fine for me as long as we keep posting final human comments :)

Note that this is not a rant about semantic-release, which is a great tool with many configuration options for many more use cases, and if it is working for you it's a solid choice.

  • I've read the contributing guidelines

@MaxGraey
Copy link
Member

So huge dependencies cleanup =)

@dcodeIO
Copy link
Member Author

dcodeIO commented Oct 25, 2020

😄 npm/cli#1973

@MaxGraey
Copy link
Member

Is it possible downgrade to npm 6.x for publish?

@dcodeIO
Copy link
Member Author

dcodeIO commented Oct 25, 2020

Alright, that worked, but looks that doing npm version in a sub-package doesn't do anything useful. Will probably have to revive the postversion script. Ah, no, scratch that, I think that's because it checks out master where the postversion script is still there.

@dcodeIO dcodeIO merged commit cf20c6c into master Oct 25, 2020
@dcodeIO dcodeIO mentioned this pull request Oct 26, 2020
@dcodeIO dcodeIO deleted the aspublish branch June 1, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants