Switch release process to aspublish #1519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retires semantic-release, which unfortunately is broken for us currently, and uses aspublish.
Aspublish is essentially a minimal replacement for what semantic-release was doing for us, but it only does what typical AS packages need (changelog -> GitHub release -> npm package) in what's essentially a single file with a couple functions, so if there are release issues in the future, we can easily fix these ourselves. Also gets rid of ~5700 lines of package-lock.json and relieves me from maintaining a fork of semantic-release due to my suggestion to handle versions less than 1.0.0 without upping to 1.0.0 being rejected.
What we are losing is bot comments on issues and PRs included in a release, which was a nice touch for contributors, but not so much for maintainers due to having to click through all of them in the morning to see if there are any human comments in between. Fine for me as long as we keep posting final human comments :)
Note that this is not a rant about semantic-release, which is a great tool with many configuration options for many more use cases, and if it is working for you it's a solid choice.