Refactor binary expression compilation to be reusable in builtins #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add also shl, shr_s and shr_u unifications/builtins plz? It required for #1495 |
|
I think the |
|
I guess we should have built-ins for of all kind of bin operations? |
|
Agree, yes, just wondering whether these can be follow-up PRs :) |
|
Yeah, just mentioned this but if it will be another pr it will be fine as well) |
|
🎉 This PR is included in version 0.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1484 it became apparent that we can share the code the compiler uses when compiling binary expressions, including taking care of SMI wrapping, during implementation of #1310, so this refactors just making the IR out of
compileBinaryExpression.