Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and fix utf-8 encoding / decoding for module #1345

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Improve and fix utf-8 encoding / decoding for module #1345

merged 2 commits into from
Jun 16, 2020

Conversation

MaxGraey
Copy link
Member

See this comment for details

  • I've read the contributing guidelines

dcodeIO
dcodeIO reviewed Jun 16, 2020
View reviewed changes
src/module.ts Show resolved Hide resolved
@MaxGraey MaxGraey changed the title Improve utf-8 encoding / decoding for module Improve and fix utf-8 encoding / decoding for module Jun 16, 2020
dcodeIO
dcodeIO reviewed Jun 16, 2020
View reviewed changes
src/module.ts Outdated Show resolved Hide resolved
@dcodeIO dcodeIO merged commit 4ed8acb into AssemblyScript:master Jun 16, 2020
@MaxGraey MaxGraey deleted the fix-utf8-enc-dec branch June 16, 2020 17:36
@github-actions
Copy link

🎉 This PR is included in version 0.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dcodeIO
Copy link
Member

dcodeIO commented Jun 17, 2020

For some reason this PR didn't make it to the changelog, and there's nothing in the log indicating why. Perhaps due to refactor(compiler):?

@MaxGraey
Copy link
Member Author

MaxGraey commented Jun 17, 2020 •
edited
Loading

I guess bot ignore such scoped commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO