Add Korean translation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
…legalArgumentException: unknown format type: 선택
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
…orean translation")
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
dzc34
added a commit
to dzc34/Contrast-Finder
that referenced
this pull request
Aug 2, 2017
---------------------- set version to 0.8.0 updated CHANGELOG + typo fixed languages menu (Asqatasun#85 "Korean translation") i18n - fixed typo (Asqatasun#85 "Korean translation") i18n - added space before "\" at the end of the line (Asqatasun#85 "Korean translation") Fixed accessibility issue: added some lang="en" (Asqatasun#85 "Korean translation") Korean added to languages menu (Asqatasun#85 "Korean translation") fixed Asqatasun#86 "Korean translation" (Asqatasun#85) - java.lang.IllegalArgumentException: unknown format type: 선택 Add Korean translation webapp - updated "Contribute to Contrast-Finder" (en + fr) Revert "Removed unused i18n entries" fix FR grammatical error fix Asqatasun#83 Removed unused i18n entries docker/build_and_run-with-docker.sh (typo) docker/build_and_run-with-docker.sh - added new option (--log-build) updated docker/build_and_run-with-docker.sh (typo) renamed docker/build_and_run-with-docker.sh fixed .gitignore set version to 0.7.1-dev
|
@miname, thank you very much. Integrated this in the new release. |
see #88 |
|
#88 is now fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified my work is based on
developbranchPurpose of this Pull Request?
To make Korean users happy. 👍
Where should the reviewer start its review?
A new file titled as "contrast-finder_utf8_ko.properties" added.
How the PR could be tested?
No breaking changes, I hope.
Any background context you want to provide?
There are two paragraphs(line no. 51 and 57) where its usage is unknown. So I just left it untouched. Could you tell me in what context the phrase being used?