-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aspen.resources API break not documented #436
Comments
Two things:
|
@pjz I tried to update Aspen for inside.gratipay.com and got some stacktrace on that. I can not continue, because I do not understand the error. I can repeat and post it here tomorrow, but maybe you can immediately say what was changed and needs to be fixed here. I think of Aspen as of pythonic PHP. |
You're going to need to provide an error for any chance of help with this. |
@pjz it was answered here - gratipay/inside.gratipay.com#263 (comment) and there is anohter trace at gratipay/inside.gratipay.com#263 (comment) which didn't occur with previous version. |
@techtonik Make a PR against Changelog, ya? |
@whit537 I don't know what to write there. I don't know what is |
|
|
See my first comment. |
Then why maintain changelog at all? |
And if that's an internal API, shouldn't it be prefixed with _? |
resources.get() changed in 0.35 from
def get(request):
https://github.com/gratipay/aspen-python/blob/0.34/aspen/resources/__init__.py#L160
to
def get(website, fspath):
https://github.com/gratipay/aspen-python/blob/0.35/aspen/resources/__init__.py#L160
With no traces in https://github.com/gratipay/aspen-python/blob/master/Changelog.md#035---released-thu-oct-30-2014-by-whit537
At the very least I expected major version bump. At maximum - migration guide.
The text was updated successfully, but these errors were encountered: