Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 204 #378

Open
chadwhitacre opened this issue Aug 14, 2014 · 3 comments
Open

support 204 #378

chadwhitacre opened this issue Aug 14, 2014 · 3 comments

Comments

@chadwhitacre
Copy link
Contributor

We should serve a 204 when a simplate content page is empty.

10.2.5 204 No Content

The server has fulfilled the request but does not need to return an entity-body, and might want to return updated metainformation. The response MAY include new or updated metainformation in the form of entity-headers, which if present SHOULD be associated with the requested variant.

If the client is a user agent, it SHOULD NOT change its document view from that which caused the request to be sent. This response is primarily intended to allow input for actions to take place without causing a change to the user agent's active document view, although any new or updated metainformation SHOULD be applied to the document currently in the user agent's active view.

The 204 response MUST NOT include a message-body, and thus is always terminated by the first empty line after the header fields.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.5

@pjz
Copy link
Contributor

pjz commented Aug 24, 2014

does 'empty' mean None? or '' ? or all-whitespace? which, or all, of those three, as output from a renderer, should cause a 204 to be raised?

@chadwhitacre
Copy link
Contributor Author

204 None
204 ''
200 all-whitespace

But, we should make sure that an empty simplate returns '' and not '\n'.

@Changaco
Copy link
Member

I'm not sure that's a good idea (implicitly changing the response code just because the page is empty).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants