Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Circle-CI configuration #9

Closed
3 tasks done
Asone opened this issue Jun 8, 2018 · 7 comments
Closed
3 tasks done

Fix Circle-CI configuration #9

Asone opened this issue Jun 8, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@Asone
Copy link
Owner

Asone commented Jun 8, 2018

Circle-CI configuration is broken. We should write a config file that handles the same build process used for Travis :

  • Environment dependencies
  • Angular & Ionic unit testing
  • Ionic building for android
@Asone Asone added the enhancement New feature or request label Jun 8, 2018
@Asone
Copy link
Owner Author

Asone commented Jun 9, 2018

Current configuration fix is blocked by an outdated node-sass package dependency declared in @ionic/app-scripts.

The provided docker-image on circle-ci currently requires node-sass to call an non-existent node binding which leads to 404 HTTP. Building from sources fails also due to missing python2 dependency.

A PR is opened here to update the node-sass package declaration so node-sass can rely to an existing node binding.

@Asone
Copy link
Owner Author

Asone commented Jun 12, 2018

PR has been merged and node-sass dependency for alpine image is fixed. see here.

We can now proceed to further steps of configuration

@Asone
Copy link
Owner Author

Asone commented Jun 12, 2018

CI seems stuck on chrome launch for testing. We'll need to configure this step in order to be able to process the tests batch before getting to the ionic build step.

@Asone
Copy link
Owner Author

Asone commented Jun 16, 2018

Fixed tests. However, test process is triggered with the default environment configuration. We should see how to detect circleci environment in order to pass the same paraters as for travis.

Once done, only ionic build will be left in order to validate CI.

@Asone
Copy link
Owner Author

Asone commented Jun 16, 2018

Concurrency fixed. Build seems to work. Last fix to provide is to remove a local Plugin that shouldn't be brought to the current repo from sources and avoid it to be called in CI.

Once done, PR will be opened to merge

@Asone
Copy link
Owner Author

Asone commented Jun 16, 2018

circle-ci build seems successful see here as travis ci also.

Opening PR.

@Asone
Copy link
Owner Author

Asone commented Jun 16, 2018

PR tests & builds successful on Travis and Circle-CI. PR Merged . Closing issue.

@Asone Asone closed this as completed Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant