[Core] Module name for sidebar

[armababy]

Problem: http://forum.asgardcms.com/topic/37/sidebar-not-showing

It seems that $module->getName() always return flat module name. Making impossible to use two+ word camel case module names.

[nWidart]

Sadly that's related to the module package, not on asgardcms.

[armababy]

Yeah was browsing pingpong saw that it returns flat name.

What if we use something like $module->get('name')?
It will return correct one from json object Module.php

Something like $name = $module->get('name', $module->getStudlyName());

[nWidart]

Interesting, this might be worth trying indeed.

[armababy]

As far as i can test it works consistently, since module will not work without module.json and required attributes we can pretty much rely on this.

vendor/ImageDimensionValue

Imagedimensionvalue | studly_case($module->getName()
imagedimensionvalue | $module->getName()
Imagedimensionvalue | $module->getStudlyName()
ImageDimensionValue | $module->get('name')

Want me to pull request or you will do it?

[n3ISe]

@armababy thanks for the solution. Double Thumbs Up

[armababy]

Damn all this studly_case, hypen, dash, camelcase situation so broken :)
Once you create camelcase module and then try to install it from repository name is getting messed up again, it creates folder with ucfirst it seems and breaks all your PSR highligting in editor since folders do not match namespaces.

The ping-pong/modules are just using lowercase name for vendor/package striping hypens, altho they are perfectly fine for package name in composer.json.

[armababy]

Fixed and merged AsgardCms/Core#85