working react example #52
Conversation
There was a problem hiding this comment.
Added some layout tips which should help.
The main thing though is - can we somehow reference what would exist in ../../dist for the libraries? We don't really want to duplicate this in public. If there is no way around it then update the README to inform the user about what they need to copy into "public".
| height: 100%; | ||
| } | ||
|
|
||
| body { |
There was a problem hiding this comment.
Change this to .App to target the React DOM class for better layout
| } | ||
|
|
||
| header { | ||
| position: relative; |
There was a problem hiding this comment.
Change to:
postion: sticky
top:0
z-index:1
For better layout
| } | ||
|
|
||
| /* OUTLINE */ | ||
|
|
There was a problem hiding this comment.
Add a new DOM target with:
#outline-panel {
position: fixed;
top: 25px;
height: 100vh;
overflow-y: scroll;
}
For better layout :)
| page_count = await worker.countPages(current_doc) | ||
|
|
||
| // Use second page as default page size (the cover page is often differently sized) | ||
| var page_size = await worker.getPageSize(current_doc, page_count > 1 ? 2 : 1) |
There was a problem hiding this comment.
Out of index by 1. Change to 1 ? 1 : 0 ( note this is also a bug in the current simple viewer, 91228c4 )
| <details> | ||
| <summary>View</summary> | ||
| <menu> | ||
| <li onClick={()=>Viewer.toggle_fullscreen()}>Fullscreen</li> |
There was a problem hiding this comment.
Weird indentation from here ....
I couldn't find a way to get it to work without copying every file from dist |
working react example
improved layout and changed readme
|
@Vilhelm-Ian Looking at what you have done here - I think the force pushes might have messed up the branch - if I look at the graphical diffs, i.e.: https://github.com/ArtifexSoftware/mupdf.js/pull/52/files I see lots of changes outside of where you should be making changes - all changes for your PR should just be to |
No description provided.