Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of REST Server for Examples #33

Merged
merged 35 commits into from
Apr 22, 2024
Merged

Implementation of REST Server for Examples #33

merged 35 commits into from
Apr 22, 2024

Conversation

mipo1357
Copy link
Collaborator

No description provided.

@jamie-lemon jamie-lemon changed the title Implementation of REST Server for Examples Draft: Implementation of REST Server for Examples Mar 18, 2024
@jamie-lemon
Copy link
Collaborator

@mipo1357 There are two things which you need to do here.

  1. The "mupdf-nextjs" folder was renames to "next's-client", please move your Next project work over to there. This should also resolve your conflicts when you move rename them
  2. Please supply up to date README for both the "rest-server" and the "nextjs-client"

Copy link
Contributor

github-actions bot commented Apr 18, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mipo1357
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@mipo1357 mipo1357 changed the title Draft: Implementation of REST Server for Examples Implementation of REST Server for Examples Apr 19, 2024
github-actions bot added a commit that referenced this pull request Apr 19, 2024
@jamie-lemon jamie-lemon merged commit 43cac25 into master Apr 22, 2024
1 check passed
@jamie-lemon jamie-lemon deleted the rest-server branch April 22, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
@jamie-lemon
Copy link
Collaborator

@mipo1357 Good stuff - working pretty well. 👍

Merged!

Could you start a new branch & PR to address the TODOs which you noted?

  • setting MetaData
  • adding text
  • adding image

It could well be that the core API needs to change for these things to work - for example setting metadata, if so let's discuss on the Discord channel. I think adding text might work, but we need to confirm what the API expects - again let's discuss on the channel.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants