diff --git a/application/front/controller/admin/PluginsController.php b/application/front/controller/admin/PluginsController.php index 0e09116e9..8e0596819 100644 --- a/application/front/controller/admin/PluginsController.php +++ b/application/front/controller/admin/PluginsController.php @@ -62,6 +62,7 @@ public function save(Request $request, Response $response): Response if (isset($parameters['parameters_form'])) { unset($parameters['parameters_form']); + unset($parameters['token']); foreach ($parameters as $param => $value) { $this->container->conf->set('plugins.'. $param, escape($value)); } diff --git a/application/plugin/PluginManager.php b/application/plugin/PluginManager.php index 7881e3bea..9f5dc0b42 100644 --- a/application/plugin/PluginManager.php +++ b/application/plugin/PluginManager.php @@ -100,20 +100,17 @@ public function load($authorizedPlugins) */ public function executeHooks($hook, &$data, $params = array()) { - if (!empty($params['target'])) { - $data['_PAGE_'] = $params['target']; - } - - if (isset($params['loggedin'])) { - $data['_LOGGEDIN_'] = $params['loggedin']; - } - - if (isset($params['basePath'])) { - $data['_BASE_PATH_'] = $params['basePath']; - } - - if (isset($params['bookmarkService'])) { - $data['_BOOKMARK_SERVICE_'] = $params['bookmarkService']; + $metadataParameters = [ + 'target' => '_PAGE_', + 'loggedin' => '_LOGGEDIN_', + 'basePath' => '_BASE_PATH_', + 'bookmarkService' => '_BOOKMARK_SERVICE_', + ]; + + foreach ($metadataParameters as $parameter => $metaKey) { + if (!empty($params[$parameter])) { + $data[$metaKey] = $params[$parameter]; + } } foreach ($this->loadedPlugins as $plugin) { @@ -128,6 +125,10 @@ public function executeHooks($hook, &$data, $params = array()) } } } + + foreach ($metadataParameters as $metaKey) { + unset($data[$metaKey]); + } } /** diff --git a/tests/PluginManagerTest.php b/tests/PluginManagerTest.php index a5d5dbe98..3012fa6c6 100644 --- a/tests/PluginManagerTest.php +++ b/tests/PluginManagerTest.php @@ -41,17 +41,23 @@ public function testPlugin(): void $this->assertTrue(function_exists('hook_test_random')); - $data = array(0 => 'woot'); + $data = [0 => 'woot']; $this->pluginManager->executeHooks('random', $data); - $this->assertEquals('woot', $data[1]); - $data = array(0 => 'woot'); + static::assertCount(2, $data); + static::assertSame('woot', $data[1]); + + $data = [0 => 'woot']; $this->pluginManager->executeHooks('random', $data, array('target' => 'test')); - $this->assertEquals('page test', $data[1]); - $data = array(0 => 'woot'); + static::assertCount(2, $data); + static::assertSame('page test', $data[1]); + + $data = [0 => 'woot']; $this->pluginManager->executeHooks('random', $data, array('loggedin' => true)); - $this->assertEquals('loggedin', $data[1]); + + static::assertCount(2, $data); + static::assertEquals('loggedin', $data[1]); } /** @@ -78,8 +84,8 @@ public function testPluginWithPhpError(): void */ public function testPluginNotFound(): void { - $this->pluginManager->load(array()); - $this->pluginManager->load(array('nope', 'renope')); + $this->pluginManager->load([]); + $this->pluginManager->load(['nope', 'renope']); $this->addToAssertionCount(1); } @@ -89,18 +95,18 @@ public function testPluginNotFound(): void public function testGetPluginsMeta(): void { PluginManager::$PLUGINS_PATH = self::$pluginPath; - $this->pluginManager->load(array(self::$pluginName)); + $this->pluginManager->load([self::$pluginName]); - $expectedParameters = array( - 'pop' => array( + $expectedParameters = [ + 'pop' => [ 'value' => '', 'desc' => 'pop description', - ), - 'hip' => array( + ], + 'hip' => [ 'value' => '', 'desc' => '', - ), - ); + ], + ]; $meta = $this->pluginManager->getPluginsMeta(); $this->assertEquals('test plugin', $meta[self::$pluginName]['description']); $this->assertEquals($expectedParameters, $meta[self::$pluginName]['parameters']); diff --git a/tests/front/controller/admin/PluginsControllerTest.php b/tests/front/controller/admin/PluginsControllerTest.php index 5b59285c9..9526474c9 100644 --- a/tests/front/controller/admin/PluginsControllerTest.php +++ b/tests/front/controller/admin/PluginsControllerTest.php @@ -32,7 +32,7 @@ public function setUp(): void array_map(function (string $plugin) use ($path) { touch($path . '/' . $plugin); }, static::PLUGIN_NAMES); } - public function tearDown() + public function tearDown(): void { $path = __DIR__ . '/folder'; array_map(function (string $plugin) use ($path) { unlink($path . '/' . $plugin); }, static::PLUGIN_NAMES); @@ -125,6 +125,7 @@ public function testSavePluginParameters(): void 'parameters_form' => true, 'parameter1' => 'blip', 'parameter2' => 'blop', + 'token' => 'this parameter should not be saved' ]; $request = $this->createMock(Request::class); @@ -143,7 +144,7 @@ public function testSavePluginParameters(): void ->with('save_plugin_parameters', $parameters) ; $this->container->conf - ->expects(static::atLeastOnce()) + ->expects(static::exactly(2)) ->method('set') ->withConsecutive(['plugins.parameter1', 'blip'], ['plugins.parameter2', 'blop']) ;